Fixing the access of scalar elements in broadcast_in_dim, clamp, and select operations
#1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmako
approved these changes
Sep 18, 2023
penagos
pushed a commit
to penagos/stablehlo
that referenced
this pull request
Sep 21, 2023
…and `select` operations (openxla#1777) Semantics of some operations like `broadcast_in_dim`, `clamp`, and `select`, with one or more of the input operands potentially be scalars, needs implicit broadcasting. For example, `operand` for `broadcast_in_dim`, `min`/`max` for `clamp`, `pred` for `select`. The current PR fixes the access of those operands, to indicate proper deference of the tensor type to element type, in the specification of these operations.
penagos
pushed a commit
to penagos/stablehlo
that referenced
this pull request
Sep 21, 2023
…and `select` operations (openxla#1777) Semantics of some operations like `broadcast_in_dim`, `clamp`, and `select`, with one or more of the input operands potentially be scalars, needs implicit broadcasting. For example, `operand` for `broadcast_in_dim`, `min`/`max` for `clamp`, `pred` for `select`. The current PR fixes the access of those operands, to indicate proper deference of the tensor type to element type, in the specification of these operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantics of some operations like
broadcast_in_dim,clamp, andselect, with one or more of the input operands potentially be scalars, needs implicit broadcasting. For example,operandforbroadcast_in_dim,min/maxforclamp,predforselect.The current PR fixes the access of those operands, to indicate proper deference of the tensor type to element type, in the specification of these operations.