Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tosa] Make legalization pass operate top-down #2501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpienaar
Copy link
Member

Some of these patterns, e.g., the reduce conversion one, assumes that the reduce op is converted before the body. But this wasn't required/enforced.

Some of these patterns, e.g., the reduce conversion one, assumes that the reduce op is converted before the body. But this wasn't required/enforced.
@jpienaar jpienaar requested a review from GleasonK August 19, 2024 21:42
Copy link

@cc10512 cc10512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it provides the right solution to converting reductions.

Would be good to also have a test case attached -- not clear to me why the test in

// CHECK-LABEL: @reduce_sum
did not catch the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants