PR #18170: Cleanup hlo_extractor and hlo_bisect dependecies #18385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_686421179
branch
2 times, most recently
from
9621305
to
39b793e
Compare
copybara-service
bot
force-pushed
the
test_686421179
branch
from
39b793e
to
27ceec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18170: Cleanup hlo_extractor and hlo_bisect dependecies
Imported from GitHub PR #18170
//xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state depend on //xla/tests:test_utils. This dependency should not exist. Moving the relevant functions to //xla:literal_util.
Copybara import of the project:
--
133e566 by Shraiysh Vaishay svaishay@nvidia.com:
Cleanup hlo_extractor and hlo_bisect dependecies
//xla/tools:hlo_extractor and //xla/tools/hlo_bisect:hlo_bisect_state
depend on //xla/tests:test_utils. This dependency should not exist.
Moving the relevant functions to //xla:literal_util.
Merging this change closes #18170
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18170 from shraiysh:cleanup_extractor_deps 133e566