[xla:scatterExpander] Extend ScatterToLoop transformation to generate correct #18662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_686266428
branch
2 times, most recently
from
74c1600
to
d4fbb67
Compare
… correct code in the presence of explicit batch dimensions. Explicit batch dimensions were recently added to scatter instructions in openxla/stablehlo#2084. This CL extends the pass to consider explicit operand batch dimensions when computing the while-loop init-value shape and the operand indices. PiperOrigin-RevId: 689450009
copybara-service
bot
force-pushed
the
test_686266428
branch
from
d4fbb67
to
212b383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xla:scatterExpander] Extend ScatterToLoop transformation to generate correct
code in the presence of explicit batch dimensions.
Explicit batch dimensions were recently added to scatter instructions in
openxla/stablehlo#2084.
This CL extends the pass to consider explicit operand batch dimensions when
computing the while-loop init-value shape and the operand indices.