[XLA:GPU] Remove untested int4 path in the Triton fusion emitter.
#18729
+68
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_689500749
branch
from
cac1bc2
to
5eebc59
Compare
`int4` support was added for only very restricted cases in the Triton matmul emitter, and was not yet intended to be supported in `triton_fusion_emitter.cc`. Make sure to explicitly remove the dependency from `triton_fusion_emitter_legacy_matmul.cc` onto `emitter_helpers.h`. The helpers were designed to be used with the new approach to Triton fusions, and the code shouldn't be shared. PiperOrigin-RevId: 689704984
copybara-service
bot
force-pushed
the
test_689500749
branch
from
5eebc59
to
4663f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Remove untested
int4path in the Triton fusion emitter.int4support was added for only very restricted cases in the Triton matmulemitter, and was not yet intended to be supported in
triton_fusion_emitter.cc.Make sure to explicitly remove the dependency from
triton_fusion_emitter_legacy_matmul.ccontoemitter_helpers.h. The helperswere designed to be used with the new approach to Triton fusions, and the code
shouldn't be shared.