fix: add close button to about overlay - #137
Open
1cbyc wants to merge 1 commit into
Open
Conversation
Signed-off-by: 1cbyc <isaacnsisong@gmail.com>
benoit74
self-requested a review
August 20, 2026 05:24
benoit74
reviewed
Aug 20, 2026
benoit74
left a comment
Collaborator
There was a problem hiding this comment.
I need more input from @kelson42
The "about" is not an overlay/popup but a dedicated page (which might look like an overlay/popup, I get it). So the "close button" implemented in this PR is a trick which navigates back to the home page. This is a trick, but since this is the only page the user might come from, it works. Is this what you expected or would you prefer we move the about to a real popup, since this also has the advantage that we do not have to decide about a background color anymore? I feel like this would make more sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
cd scraper && .venv/bin/python -m pytest -q tests/test_processor.py -k 'about_html'cd scraper && .venv/bin/ruff check src/maps2zim/processor.py tests/test_processor.pycd scraper && .venv/bin/ruff format --check src/maps2zim/processor.py tests/test_processor.pygit diff --checkFixes #134