ci: deploys bom separately to allow re-do on partial failure #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the bom project deployed only after the parent succeeded. This meant a timeout would prevent it from being deployed, even if the timeout was not critical. This deploys the bom independently so that such a situation doesn't cause us to have to re-cut a version. This also fixes where we didn't actually use the release args in tests. Signed-off-by: Adrian Cole <adrian@tetrate.io>
|
this can be tested prior to release as it also runs on master |
| @@ -69,4 +69,4 @@ jobs: | |||
| # via forks, and login session ends up in ~/.docker. This is ok because | |||
| # we publish DOCKER_PARENT_IMAGE to ghcr.io, hence local to the runner. | |||
| - name: Test | |||
| run: build-bin/configure_test && build-bin/test | |||
| run: build-bin/configure_test && build-bin/test ${{ matrix.maven_args }} | |||
There was a problem hiding this comment.
@reta I feel like this copy/paste is missing elsewhere, too ;) that said I think the only ones that are critical on this are zipkin, reporter and brave, as they have java 6 artifacts..
There was a problem hiding this comment.
Got it, thanks @codefromthecrypt !
|
will watch https://github.com/openzipkin/zipkin-reporter-java/actions/runs/7468624673 for success |
|
worked.. will cut 3.1.1 and hope the sonatype snafu is over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the bom project deployed only after the parent succeeded. This meant a timeout would prevent it from being deployed, even if the timeout was not critical. This deploys the bom independently so that such a situation doesn't cause us to have to re-cut a version.
This also fixes where we didn't actually use the release args in tests.