Introduce RBAC Toggle Enhancement #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
awgreene
force-pushed
the
rbac-toggle
branch
2 times, most recently
from
7af7737
to
fde8733
Compare
Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
grokspawn
reviewed
Jun 10, 2022
| - The existing [CustomResourceDefinition (CRD)](https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/) primitive does not provide a great user experience on multitenant environments. | ||
| - It becomes increasingly complex when a user installs multiple versions of an operator scoped to different namespaces. | ||
|
|
||
| As more operators move towards the cluster scoped model, it becomes increasingly problematic for cluster admins that are uncomfortable or unable to allow OLM to grant cluster wide RBAC to operators it installs. |
There was a problem hiding this comment.
nit:
Suggested change
| As more operators move towards the cluster scoped model, it becomes increasingly problematic for cluster admins that are uncomfortable or unable to allow OLM to grant cluster wide RBAC to operators it installs. | |
| As more operators move towards the cluster scoped model, it becomes increasingly problematic for cluster admins that are uncomfortable or unable to allow OLM to grant cluster wide RBAC to installed operators. |
|
|
||
| ### Version Skew Strategy | ||
|
|
||
| The is feature does not depend on other projects and uses existing APIs, as such there is little concern regarding the version of other components. |
There was a problem hiding this comment.
Suggested change
| The is feature does not depend on other projects and uses existing APIs, as such there is little concern regarding the version of other components. | |
| This feature does not depend on other projects and uses existing APIs, as such there is little concern regarding the version of other components. |
|
|
||
| ## Drawbacks | ||
|
|
||
| The goal of this enhancement is to provide cluster admins with greater control over the RBAC that OLM generates on cluster. Providing cluster admin's with the means to disable OLM's RBAC generation naturally places a greater burden on cluster admins to manage RBAC as they install new operators. There are a number of existing processes that become more tedious when RBAC generation is disabled, to name a few: |
There was a problem hiding this comment.
Suggested change
| The goal of this enhancement is to provide cluster admins with greater control over the RBAC that OLM generates on cluster. Providing cluster admin's with the means to disable OLM's RBAC generation naturally places a greater burden on cluster admins to manage RBAC as they install new operators. There are a number of existing processes that become more tedious when RBAC generation is disabled, to name a few: | |
| The goal of this enhancement is to provide cluster admins with greater control over the RBAC that OLM generates on cluster. Providing cluster admins with the means to disable OLM's RBAC generation naturally places a greater burden on cluster admins to manage RBAC as they install new operators. There are a number of existing processes that become more tedious when RBAC generation is disabled, to name a few: |
|
|
||
| - The cluster admin must keep track of the namespaces that include the roles and roleBindings required by the operator. If the cluster admin wants to extend the scope of the operator to additional namespaces, they would need to create additional RBAC in said namespaces. | ||
| - The cluster admin must keep the `WATCHED_NAMESPACES` environment variable up to date, otherwise the informer will: | ||
| -- Receive events from namespaces that it lacks the appropriate RBAC. |
There was a problem hiding this comment.
Suggested change
| -- Receive events from namespaces that it lacks the appropriate RBAC. | |
| -- Receive events from namespaces it has no appropriate RBAC to handle. |
| - The cluster admin must keep track of the namespaces that include the roles and roleBindings required by the operator. If the cluster admin wants to extend the scope of the operator to additional namespaces, they would need to create additional RBAC in said namespaces. | ||
| - The cluster admin must keep the `WATCHED_NAMESPACES` environment variable up to date, otherwise the informer will: | ||
| -- Receive events from namespaces that it lacks the appropriate RBAC. | ||
| -- Not Receive events from namespaces that it has the appropriate RBAC. |
There was a problem hiding this comment.
Suggested change
| -- Not Receive events from namespaces that it has the appropriate RBAC. | |
| -- Not Receive events from namespaces for which it has the appropriate RBAC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.