-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): split integration tests execution by category #2548
base: next
Are you sure you want to change the base?
Conversation
407deaf
to
bfc718b
Compare
@metacosm could youd tell what exactly we try to solve with this? |
Runtime length but also easier diagnosing of issues with shorter logging. |
a2977ad
to
73da7f8
Compare
Also avoid generating CRDs when not needed by default, summarizes test results. Signed-off-by: Chris Laprun <claprun@redhat.com>
Well, now we have maybe shorter log files, but 81 runs, which is not nice on it's own. So the problem that this solved is the large log files? At least for me is not the problem to download it in raw format, and do a search on the unit test name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I don't have big objection against this, just let's have a rational behind it at least in comments.
Why do you think more runs are an issue? (I mean I have some opinions on this but I'd like to hear your rationale)
Shorter logs make it easier / faster to see what's going on from CI directly instead of having to manually check it out on your computer by downloading the logs. |
Signed-off-by: Chris Laprun <claprun@redhat.com>
Not a big issues just simpler to see the structure if is shorter / simpler.
TBH this would omit in future if we see there are no more issues with this, since it's not our responsibility to test the client. But ok for now. We should probably test eventually just with vertex (AFAIK that is what fabric8 recommends) |
Maybe we could limit http client flavor tests to low level API. |
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun claprun@redhat.com