Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): split integration tests execution by category #2548

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

metacosm
Copy link
Collaborator

Signed-off-by: Chris Laprun claprun@redhat.com

@metacosm metacosm self-assigned this Oct 10, 2024
@metacosm metacosm force-pushed the split-its branch 9 times, most recently from 407deaf to bfc718b Compare October 10, 2024 17:04
@csviri
Copy link
Collaborator

csviri commented Oct 10, 2024

@metacosm could youd tell what exactly we try to solve with this?
The main concern is the runtime length?

@metacosm
Copy link
Collaborator Author

Runtime length but also easier diagnosing of issues with shorter logging.

@metacosm metacosm force-pushed the split-its branch 6 times, most recently from a2977ad to 73da7f8 Compare October 11, 2024 15:34
Also avoid generating CRDs when not needed by default, summarizes test
results.

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
Copy link
Collaborator

csviri commented Oct 15, 2024

Well, now we have maybe shorter log files, but 81 runs, which is not nice on it's own. So the problem that this solved is the large log files?

At least for me is not the problem to download it in raw format, and do a search on the unit test name.

Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean I don't have big objection against this, just let's have a rational behind it at least in comments.

@metacosm
Copy link
Collaborator Author

Well, now we have maybe shorter log files, but 81 runs, which is not nice on it's own. So the problem that this solved is the large log files?

Why do you think more runs are an issue? (I mean I have some opinions on this but I'd like to hear your rationale)
We now run more tests (especially now all the integration tests are run using all HTTP client implementations). We could, of course, decide that we don't need to do this to reduce the number of different runs.

At least for me is not the problem to download it in raw format, and do a search on the unit test name.

Shorter logs make it easier / faster to see what's going on from CI directly instead of having to manually check it out on your computer by downloading the logs.

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri
Copy link
Collaborator

csviri commented Oct 15, 2024

Why do you think more runs are an issue? (I mean I have some opinions on this but I'd like to hear your rationale)

Not a big issues just simpler to see the structure if is shorter / simpler.

We now run more tests (especially now all the integration tests are run using all HTTP client implementations)

TBH this would omit in future if we see there are no more issues with this, since it's not our responsibility to test the client. But ok for now. We should probably test eventually just with vertex (AFAIK that is what fabric8 recommends)

@csviri
Copy link
Collaborator

csviri commented Oct 15, 2024

Maybe we could limit http client flavor tests to low level API.

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants