-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chainsaw scorecard test support #6676
base: master
Are you sure you want to change the base?
feat: add chainsaw scorecard test support #6676
Conversation
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@@ -0,0 +1,37 @@ | |||
# Build the scorecard-test-chainsaw binary | |||
FROM --platform=$BUILDPLATFORM golang:1.21 as builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Operator-SDK has the intention to begin to support chainsaw, I think you will need to add an e2e test for those as well. see; https://github.com/operator-framework/operator-sdk/blob/master/test/e2e/go/scorecard_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can work on that later today :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before working on it, I suggest contacting the SDK maintainers in the operator-SDK-dev slack channel to see if they are willing to add it to the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Hi @eddycharly, I believe this PR should be closed. From what I understand, there doesn't seem to be an appetite within the project to add this support. |
Description of the change:
Add chainsaw scorecard test support.
Motivation for the change:
Chainsaw is a tool to run operators/controllers tests.
It is similar to kuttl but with a more modern and flexible approach.
It would be nice to add chainsaw scorecard into operator-sdk.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs