Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names #6709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

depthlending
Copy link

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: depthlending <bikangning@outlook.com>
@depthlending
Copy link
Author

Anything need I to do?

@grokspawn
Copy link
Contributor

grokspawn commented Apr 29, 2024

It looks like you just need to rebase this PR. #6691 updated the testdata already (which should've been done as part of the new tag/release, but wasn't).
So the failures should go away after that.

@grokspawn
Copy link
Contributor

/override sanity/docs

Copy link

openshift-ci bot commented Apr 29, 2024

@grokspawn: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • sanity/docs

Only the following failed contexts/checkruns were expected:

  • DCO
  • docs
  • e2e
  • goreleaser
  • integration
  • netlify/operator-sdk/deploy-preview
  • sanity
  • unit

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override sanity/docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor

/override docs

Copy link

openshift-ci bot commented Apr 29, 2024

@grokspawn: Overrode contexts on behalf of grokspawn: docs

In response to this:

/override docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@depthlending
Copy link
Author

friendly ping~

@acornett21
Copy link
Contributor

@depthlending Can you rebase, so we can make sure all tests pass? Thanks.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants