Skip to content

[OP-19932] Ckeditor toolbar is partially offscreen on work package description - #24830

Open
bsatarnejad wants to merge 1 commit into
release/17.8from
op-19932-ckeditor-toolbar-is-partially-offscreen-on-work-package-description
Open

[OP-19932] Ckeditor toolbar is partially offscreen on work package description#24830
bsatarnejad wants to merge 1 commit into
release/17.8from
op-19932-ckeditor-toolbar-is-partially-offscreen-on-work-package-description

Conversation

@bsatarnejad

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/OP-19932

What are you trying to accomplish?

Fix the CKEditor grouped toolbar overflowing the work package description when the surrounding split panes reduce the editor width.
The grouped dropdown is now constrained relative to the toolbar container using CSS container-query units. It keeps its natural width when only a few controls overflow and wraps controls when additional space is required.

@bsatarnejad bsatarnejad changed the title Wrap ck editor items [OP-19932] Ckeditor toolbar is partially offscreen on work package description Aug 19, 2026
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/team_planner/spec/features/team_planner_overview_spec.rb[1:4:4:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24830, linked for reference only):

- `rspec ./modules/team_planner/spec/features/team_planner_overview_spec.rb[1:4:4:1]`

Treat this as a standalone task, unrelated to PR #24830. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24830 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @bsatarnejad to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @bsatarnejad, and request a review from @bsatarnejad.
On every commit, set @bsatarnejad as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@bsatarnejad
bsatarnejad marked this pull request as ready for review August 19, 2026 10:08
@bsatarnejad bsatarnejad self-assigned this Aug 19, 2026

@dfriquet dfriquet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL more about container media queries in action 👍

And of course, I like the idea of replacing JS with CSS for presentation purpose 🖌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants