More token fetching - #24848
Open
NobodysNightmare wants to merge 4 commits into
Open
Conversation
NobodysNightmare
marked this pull request as draft
August 20, 2026 07:20
NobodysNightmare
force-pushed
the
more-token-fetching
branch
from
August 20, 2026 13:47
e076300 to
998b2d9
Compare
The method was intended to obtain an access token, but its only usage was to check for the presence of a user-connection. It has been replaced appropriately.
There was a capability to refresh access tokens, including a try-and-error method to perform a code block and retry it with a refreshed token. However, both were not used at all.
NobodysNightmare
force-pushed
the
more-token-fetching
branch
from
August 21, 2026 06:16
998b2d9 to
6bbbf7c
Compare
NobodysNightmare
marked this pull request as ready for review
August 21, 2026 06:16
| @@ -51,7 +51,7 @@ See COPYRIGHT and LICENSE files for more details. | |||
| %> | |||
|
|
|||
| <%# TODO: temp — move to a dedicated per-user connection status component once designed %> | |||
Contributor
Author
There was a problem hiding this comment.
This joke doesn't get old xD
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #24726, targeting
dev. It uses the newly introducedTokenFetcherin more places and removes a few unused methods that were directly dealing withOAuthClientToken, but didn't have any callers anymore.Tickets
https://community.openproject.org/wp/SI-238