Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats preview card component #146

Open
wants to merge 16 commits into
base: stats_preview_card_component
Choose a base branch
from
Open

Stats preview card component #146

wants to merge 16 commits into from

Conversation

ngumokenneth
Copy link

stats_preview_card_component-desktop
stats_preview_card_component-mobile

almirsarajcic
almirsarajcic requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match the design. There's so much room for improvement.

The location of the image files is incorrect.

@ngumokenneth
adjusted the width of the images, adjusted the padding and margins of…
259f6e3 
… text, changed the font moved the images directory into the stats_preview_card_component
@ngumokenneth
adjusted the background color
a59df83
almirsarajcic
almirsarajcic requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary changes in the diff.

almirsarajcic
almirsarajcic requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some unnecessary file changes.
You shouldn't touch favicons. They aren't a part of challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngumokenneth @almirsarajcic