Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faq accordion card #148

Open
wants to merge 7 commits into
base: faq_accordion_card
Choose a base branch
from
Open

Faq accordion card #148

wants to merge 7 commits into from

Conversation

ngumokenneth
Copy link

faq_accordion_card-desktop
faq_accordion_card-mobile

almirsarajcic
almirsarajcic requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some unnecessary file changes. Check the Files changes tab.
Otherwise, looks good.

@ngumokenneth
Copy link
Author

I can't find the unnecessary diff. Looks good to me.

@almirsarajcic
Copy link
Member

I can't find the unnecessary diff. Looks good to me.

I'm referring to the images. You moved favicons and other images.

@ngumokenneth
Copy link
Author

I get it now.

almirsarajcic
almirsarajcic requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong images directory location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngumokenneth @almirsarajcic