Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive pricing component #149

Open
wants to merge 12 commits into
base: interactive_pricing_component
Choose a base branch
from
Open

Interactive pricing component #149

wants to merge 12 commits into from

Conversation

ngumokenneth
Copy link

interactive_pricing_component-desktop
interactive_pricing_component-mobile

almirsarajcic
almirsarajcic requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are unnecessary file changes in the diff.

challenges/interactive_pricing_component/index.html Outdated Show resolved Hide resolved
almirsarajcic
almirsarajcic requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing and the UI can be improved.

challenges/style.css Outdated Show resolved Hide resolved
challenges/interactive_pricing_component/index.html Outdated Show resolved Hide resolved
almirsarajcic
almirsarajcic requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve the UI and refactor the logic.

challenges/interactive_pricing_component/index.html Outdated Show resolved Hide resolved
almirsarajcic
almirsarajcic requested changes Nov 6, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI needs to be improved. Please check the generated screenshots under Checks -> Artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngumokenneth @almirsarajcic