Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qr code component #165

Open
wants to merge 4 commits into
base: qr_code_component
Choose a base branch
from
Open

Qr code component #165

wants to merge 4 commits into from

Conversation

mbashia
Copy link

@mbashia mbashia commented Aug 12, 2024

No description provided.

@almirsarajcic almirsarajcic reopened this Aug 13, 2024
almirsarajcic
almirsarajcic requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing.
Also, you've committed and pushed some unnecessary files like READMEs, extra images, etc.

challenges/index.html Outdated Show resolved Hide resolved
challenges/qr_code_component_main/README-template.md Outdated Show resolved Hide resolved
challenges/qr_code_component_main/README.md Outdated Show resolved Hide resolved
challenges/qr_code_component_main/style-guide.md Outdated Show resolved Hide resolved
tailwind.config.js Outdated Show resolved Hide resolved
src/styles.css Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
almirsarajcic
almirsarajcic requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are still failing (https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/10369974217/job/28717872421?pr=165). Execute npm run test locally to run the tests.

Files are still in the wrong location, and also there are still some extra files.

challenges/index.html Outdated Show resolved Hide resolved
@mbashia
Copy link
Author

mbashia commented Aug 13, 2024

The tests are still failing (https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/10369974217/job/28717872421?pr=165). Execute npm run test locally to run the tests.

Files are still in the wrong location, and also there are still some extra files.

My test are passing locally

@mbashia
Copy link
Author

mbashia commented Aug 13, 2024

Let me go through it again, and correct where necessary

almirsarajcic
almirsarajcic requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, but it doesn't match the design exactly (paddings, margins, line height etc.).
https://www.frontendmentor.io/challenges/qr-code-component-iux_sIO_H
Screenshot 2024-08-15 at 12 18 13

@mbashia
Copy link
Author

mbashia commented Aug 15, 2024

Much better, but it doesn't match the design exactly (paddings, margins, line height etc.). https://www.frontendmentor.io/challenges/qr-code-component-iux_sIO_H Screenshot 2024-08-15 at 12 18 13

Improving this on the next four exercises

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbashia @almirsarajcic