Lunar Module Additions/Updates #1309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases. RedMelon is the goat for figuring this out
Add EVA handle switch
…into LM_Additions
Set LMHasCask to FALSE in the mission config file
Fixed dumb typo
Linked handle and animation code together
|
Can you please make your commits atomic? |
|
What do you mean by "atomic"? I have not heard that when talking about commits. This is my first real big PR, so i apologize in advance. |
|
This post explains atomic commits: https://www.pauline-vos.nl/atomic-commits/ Keeping this in mind from the start will make everyones lives easier. |
|
Ill keep that in mind for future PRs. no one told me to do it that way so i assumed i was fine |
|
This will conflict with #1235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a list of what is being changed/added in no particular order:
Improved black thermal blanket texture (based on mission photos)
Landing Radar and its associated animation, controlled either manually with the switch on P3, or by the LGC
Added LR heat shield
Added ALSEP RTG Fuel Cask, can be toggled with "LMHasCask" flag in the mission config (this has already been updated for the default missions, 9-11 do not have cask)
Added black thermal blankets to the LM footpads (based on mission/closeout photos)
Added normal map for RCS jets for some nice extra detail
Added mesh for the Omni S-Band antennae on the ascent stage
Added EVA VHF antenna and its animation, toggled with a handle in the VC
Added Kapton Tape to the silver foil in the S-Band and VHF antenna mounts (as seen in mission photos)
Added AES Radiator on the bottom of the Ascent Stage
Huge thanks to the NASSP Dev Team for answering all my questions about programing for orbiter, shoutouts to @maxq519, @Jordan-64, @CaptainSwag101, @rcflyinghokie, @ThatRedMelon, and others that I may have forgotten.