Adjust all type-specific/rule-dedicated methods to check only their own validation rule - #40
Open
Neluxx wants to merge 15 commits into
Open
Adjust all type-specific/rule-dedicated methods to check only their own validation rule#40Neluxx wants to merge 15 commits into
Neluxx wants to merge 15 commits into
Conversation
ravage84
requested changes
Aug 26, 2026
ravage84
left a comment
ravage84
left a comment
Member
There was a problem hiding this comment.
I think this will be a big step forward! 🙏
| */ | ||
| public function testTypeSpecificMethodIgnoresUnrelatedErrors(): void | ||
| { | ||
| $field = 'multi_rule_field'; |
Member
There was a problem hiding this comment.
Shouldn't we test all methods that now ignore other rules against this field, too? 🤔
That in turn would (almost) double the amount of fields because for each {rule}_field we would also need a field that has this rule and at least one other...
Member
Author
There was a problem hiding this comment.
The "ignore unrelated errors" logic lives in the shared testDataValidationContains / testDataValidationNotContains helpers, so testDataValidationInteger is enough to prove the wiring. Testing every method would just re-exercise the same path and double the fixtures for little gain. Happy to add full coverage if you'd prefer.
…assert build rules.
Co-authored-by: Marc Würth <ravage@bluewin.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38