Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Production Release #4

wants to merge 5 commits into from

Conversation

ordermentumbot
Copy link

Production Release

@ordermentum
Copy link

ordermentum bot commented Nov 11, 2019

Please make sure to add screenshots or gifs of the change to give a clear
picture of the change. If a design PR was made please make sure to link to it along with the
JIRA ticket. A Design PR will avoid unnecessary rework that might come up in a PR.

Good Pull Requests adhere to a single responsibility.

  • Break big changes into smaller Pull Requests
  • Big changes increase risk - smaller PRs are easier to review
  • Refactoring changes should be in seperate PRs to avoid noise
  • A story/ticket can have more than 1 PR

Some guidelines on giving and receiving feedback in Code Reviews

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants