Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register kima mainet asset #1930

Closed
wants to merge 4 commits into from
Closed

Conversation

dawn227
Copy link
Contributor

@dawn227 dawn227 commented Sep 27, 2024

Description

Checklist

Adding Assets

If adding a new asset, please ensure the following:

  • Asset is registered to the Cosmos Chain Registry.
  • Add asset to bottom of zone_assets.json.
    • chain_name and base_denom are provided and use values exactly as defined at the Chain Registry.
    • path is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).
    • osmosis_verified is set to false
    • listing_date_time_utc is specified and accurate
    • Optional: transfer_methods, peg_mechanism, override_properties, canonical, categories, where necessary (see README for details).
  • I am aware that upgrading an asset to 'verified' status requires an additional PR to this repo (checklist below).

Adding Chains

If adding a new chain, please ensure the following:

  • Chain is registered to the Cosmos Chain Registry.
    • Chain's registration must have staking defined, with at least one staking_token denom specified.
    • Chain's registration must have fees defined; at least one fee token has low, average, and high gas prices defined.
  • IBC Connection between chain and Osmosis is registered.
  • Add chain to bottom of zone_chains.json
    • rpc and rest does not have any CORS blocking of the Osmosis domain, and RPC node has have WSS enabled.
    • explorer_tx_url correctly directs to the transaction when the hash is inserted into the URL.

@JeremyParish69 JeremyParish69 marked this pull request as draft October 1, 2024 17:40
@dawn227 dawn227 marked this pull request as ready for review October 1, 2024 18:34
"wasmd_0.24+",
"osmosis-txfees"
]
"keplr_features": ["ibc-go", "ibc-transfer", "cosmwasm", "wasmd_0.24+", "osmosis-txfees"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please undo the update of the formatting so it doesn't change the whole file?
[
"new line",
"for each"
]

package-lock.json
.prettierrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this come from?

@JeremyParish69 JeremyParish69 marked this pull request as draft October 2, 2024 17:23
@dawn227 dawn227 closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants