makePrepareMintTOkenParams returns single object

ourzora · Nov 16, 2023 · 1a04173 · 1a04173
1 parent 597559d
commit 1a04173
Show file tree

Hide file tree

Showing 3 changed files with 193 additions and 164 deletions.
diff --git a/.changeset/chilled-seahorses-protect.md b/.changeset/chilled-seahorses-protect.md
@@ -0,0 +1,11 @@
+---
+"@zoralabs/protocol-sdk": patch
+---
+
+`MintClient.makePrepareMintTokenParams` has the following changes:
+  * returns a `SimulateContractParams`, instead of an object containing it indexed by key
+  * PublicClient as an optional argument
+
+
+Internally, MintClient is refactored to extract some functionality into static helpers that could eventually be publicly exposed
+
diff --git a/packages/protocol-sdk/src/mint/mint-client.test.ts b/packages/protocol-sdk/src/mint/mint-client.test.ts
@@ -23,19 +23,18 @@ describe("mint-helper", () => {
       const targetTokenId = 1n;
       const minter = createMintClient({ chain: zora });
 
-      const { simulateContractParameters: params } =
-        await minter.makePrepareMintTokenParams({
-          publicClient,
-          minterAccount: creatorAccount,
-          mintable: await minter.getMintable({
-            tokenId: targetTokenId,
-            tokenContract: targetContract,
-          }),
-          mintArguments: {
-            mintToAddress: creatorAccount,
-            quantityToMint: 1,
-          },
-        });
+      const params = await minter.makePrepareMintTokenParams({
+        publicClient,
+        minterAccount: creatorAccount,
+        mintable: await minter.getMintable({
+          tokenId: targetTokenId,
+          tokenContract: targetContract,
+        }),
+        mintArguments: {
+          mintToAddress: creatorAccount,
+          quantityToMint: 1,
+        },
+      });
 
       const oldBalance = await publicClient.readContract({
         abi: zoraCreator1155ImplABI,
@@ -75,27 +74,26 @@ describe("mint-helper", () => {
       const targetTokenId = undefined;
       const minter = createMintClient({ chain: zora });
 
-      const { simulateContractParameters: prepared } =
-        await minter.makePrepareMintTokenParams({
-          mintable: await minter.getMintable({
-            tokenContract: targetContract,
-            tokenId: targetTokenId,
-          }),
-          publicClient,
-          minterAccount: creatorAccount,
-          mintArguments: {
-            mintToAddress: creatorAccount,
-            quantityToMint: 1,
-          },
-        });
+      const params = await minter.makePrepareMintTokenParams({
+        mintable: await minter.getMintable({
+          tokenContract: targetContract,
+          tokenId: targetTokenId,
+        }),
+        publicClient,
+        minterAccount: creatorAccount,
+        mintArguments: {
+          mintToAddress: creatorAccount,
+          quantityToMint: 1,
+        },
+      });
       const oldBalance = await publicClient.readContract({
         abi: erc721ABI,
         address: targetContract,
         functionName: "balanceOf",
         args: [creatorAccount],
       });
 
-      const simulated = await publicClient.simulateContract(prepared);
+      const simulated = await publicClient.simulateContract(params);
 
       const hash = await walletClient.writeContract(simulated.request);