Skip to content

Commit

Permalink
wip on getting list of versions instead
Browse files Browse the repository at this point in the history
  • Loading branch information
oveddan committed Oct 31, 2023
1 parent aca2a38 commit 8947227
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,10 @@ contract ZoraCreator1155PremintExecutorImpl is
/// @param contractAddress The address of the contract to check
/// @return The version of the premint signature that the contract supports. If it doesn't support premint
/// returns 0
function supportedPremintSignatureVersion(address contractAddress) external view returns (string memory) {
function supportedPremintSignatureVersions(address contractAddress) external view returns (string memory) {
IZoraCreator1155 creatorContract = IZoraCreator1155(contractAddress);
if (creatorContract.supportsInterface(type(IZoraCreator1155DelegatedCreation).interfaceId)) {
return IZoraCreator1155DelegatedCreation(contractAddress).supportedPremintSignatureVersion();
return IZoraCreator1155DelegatedCreation(contractAddress).supportedPremintSignatureVersions();
}

// try get token id for uid 0 - if call fails, we know this didn't support premint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pragma solidity 0.8.17;
interface IZoraCreator1155DelegatedCreation {
event CreatorAttribution(bytes32 structHash, string domainName, string version, address creator, bytes signature);

function supportedPremintSignatureVersion() external pure returns (string memory);
function supportedPremintSignatureVersions() external pure returns (string memory);

function delegateSetupNewToken(
bytes memory premintConfigEncoded,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,5 @@ interface IZoraCreator1155PremintExecutor is

function getContractAddress(ContractCreationConfig calldata contractConfig) external view returns (address);

function supportedPremintSignatureVersion(address contractAddress) external view returns (string memory);
function supportedPremintSignatureVersions(address contractAddress) external view returns (string memory);
}
2 changes: 1 addition & 1 deletion packages/1155-contracts/src/nft/ZoraCreator1155Impl.sol
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ contract ZoraCreator1155Impl is
return _getImplementation();
}

function supportedPremintSignatureVersion() external pure returns (string memory) {
function supportedPremintSignatureVersions() external pure returns (string memory) {
return ZoraCreator1155Attribution.VERSION_2;
}

Expand Down

0 comments on commit 8947227

Please sign in to comment.