If no mint recipient, default to msg.sender

ourzora · Nov 14, 2023 · f69802c · f69802c
1 parent 58b0ceb
commit f69802c
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/packages/1155-contracts/src/delegation/ZoraCreator1155PremintExecutorImpl.sol b/packages/1155-contracts/src/delegation/ZoraCreator1155PremintExecutorImpl.sol
@@ -17,7 +17,7 @@ import {PremintEncoding, ZoraCreator1155Attribution, ContractCreationConfig, Pre
 import {IZoraCreator1155PremintExecutor} from "../interfaces/IZoraCreator1155PremintExecutor.sol";
 
 struct MintArguments {
-    // which account should receive the tokens minted.  If set to address(0), then defaults to the msg.sender
+    // which account should receive the tokens minted.
     address mintRecipient;
     // comment to add to the mint
     string mintComment;

diff --git a/packages/1155-contracts/src/interfaces/IZoraCreator1155Errors.sol b/packages/1155-contracts/src/interfaces/IZoraCreator1155Errors.sol
@@ -36,4 +36,6 @@ interface IZoraCreator1155Errors is ICreatorRoyaltyErrors, ILimitedMintPerAddres
     error PremintDeleted();
 
     error InvalidSignatureVersion();
+
+    error ERC1155_MINT_TO_ZERO_ADDRESS();
 }
diff --git a/packages/1155-contracts/test/premint/ZoraCreator1155PremintExecutor.t.sol b/packages/1155-contracts/test/premint/ZoraCreator1155PremintExecutor.t.sol
@@ -737,6 +737,33 @@ contract ZoraCreator1155PreminterTest is Test {
         assertEq(storedCreateReferral, createReferral);
     }
 
+    function test_premintWithNoMintRecipient_reverts() public {
+        ContractCreationConfig memory contractConfig = makeDefaultContractCreationConfig();
+        PremintConfigV2 memory premintConfig = makeDefaultPremintConfig();
+
+        address contractAddress = preminter.getContractAddress(contractConfig);
+
+        // sign and execute premint
+        bytes memory signature = _signPremint(contractAddress, premintConfig, creatorPrivateKey, block.chainid);
+
+        IZoraCreator1155PremintExecutor.MintArguments memory mintArguments = IZoraCreator1155PremintExecutor.MintArguments({
+            mintRecipient: address(0),
+            mintComment: "",
+            mintReferral: address(0)
+        });
+
+        uint256 quantityToMint = 3;
+        uint256 mintCost = mintFeeAmount * quantityToMint;
+        address executor = makeAddr("executor");
+        vm.deal(executor, mintCost);
+
+        // now call the premint function, using the same config that was used to generate the digest, and the signature
+        vm.prank(executor);
+        vm.expectRevert(IZoraCreator1155Errors.ERC1155_MINT_TO_ZERO_ADDRESS.selector);
+
+        preminter.premintV2{value: mintCost}(contractConfig, premintConfig, signature, quantityToMint, mintArguments).tokenId;
+    }
+
     function _signAndExecutePremint(
         ContractCreationConfig memory contractConfig,
         PremintConfigV2 memory premintConfig,