-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: creator reward recipient per token #278
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4c7f902
refactor: add token royalty recipient override
kulkarohan 53ad111
chore: add tests for recipient conditions
kulkarohan df796ff
perf: optimize conditional returns
kulkarohan 25b5b99
chore: lint
kulkarohan a7fe34c
refactor: update return type
kulkarohan 57618c2
chore: update tests
kulkarohan 3230be9
perf: cache recipient
kulkarohan 80edfa5
chore: update tests
kulkarohan a7acd49
chore: testnet deploy
kulkarohan fc24b3a
chore: add changeset
kulkarohan 463c3cc
Merge pull request #281 from ourzora/creator_reward_recipient_per_token
kulkarohan 3ade5a5
chore: remove temp fork tests
kulkarohan edb0ba0
chore: add upgrade gate to chain configs
kulkarohan b0e86d5
better comments/changeset
oveddan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kulkarohan can we check the front-end and subgraph to make sure there are no calls to this function?
Would it make sense to make this internal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed - no frontend and subgraph usage of this function (yet)
i believe however frontend is planning to pin the creator reward recipient address on each token page, so i think having it public to fetch would make their lives easier, at little cost to us since we need it anyways.
but can confirm w them and if they're not can just make this internal