Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): Allow maxValueSize as option #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Schartey
Copy link

@Schartey Schartey commented Apr 6, 2022

The maximum allowed value size was hardcoded to 1mb.
To allow storing bigger values I added the option MaxValueSize that can be set on badger initialization.


This change is Reviewable

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@poonai
Copy link
Collaborator

poonai commented Apr 8, 2022

@Schartey Thanks for the contribution.

Please sign the contributor agreement for us to merge the PR.

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be good to have a test which writes large values and is able to retrieve them fine, after having closed the DB and re-opened it.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jarifibrahim)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants