Skip to content

Commit

Permalink
feat!: upgrade mysql to 8.4.0 (#1071)
Browse files Browse the repository at this point in the history
  • Loading branch information
rohan-saeed authored Jun 7, 2024
1 parent cf6ac56 commit 3d5e8fa
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions changelog.d/20240531_132815_rohan.saeed_supply_mysql8_4_0.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- 💥[Improvement] Upgrade MySQL to 8.4.0 (by @rohansaeed)
The upgrade should be automatic for most users. However, if you are running a third-party MySQL (i.e., RUN_MYSQL=false), you are expected to upgrade manually. Please refer to the third-party provider's documentation for detailed upgrade instructions. Ensuring that your MySQL version is up-to-date is crucial for maintaining compatibility and security.
2 changes: 1 addition & 1 deletion docs/configuration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ This configuration parameter defines which MongoDB Docker image to use.

.. https://hub.docker.com/_/mysql/tags?page=1&name=8.0
- ``DOCKER_IMAGE_MYSQL`` (default: ``"docker.io/mysql:8.1.0"``)
- ``DOCKER_IMAGE_MYSQL`` (default: ``"docker.io/mysql:8.4.0"``)

This configuration parameter defines which MySQL Docker image to use.

Expand Down
2 changes: 1 addition & 1 deletion tests/commands/test_images.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_images_pull_all_vendor_images(self, image_pull: Mock) -> None:
self.assertIsNone(result.exception)
self.assertEqual(0, result.exit_code)
# Note: we should update this tag whenever the mysql image is updated
image_pull.assert_called_once_with("docker.io/mysql:8.1.0")
image_pull.assert_called_once_with("docker.io/mysql:8.4.0")

def test_images_printtag_image(self) -> None:
result = self.invoke(["images", "printtag", "openedx"])
Expand Down
2 changes: 1 addition & 1 deletion tutor/templates/config/defaults.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ DOCKER_IMAGE_ELASTICSEARCH: "docker.io/elasticsearch:7.17.13"
# https://hub.docker.com/_/mongo/tags
DOCKER_IMAGE_MONGODB: "docker.io/mongo:7.0.7"
# https://hub.docker.com/_/mysql/tags
DOCKER_IMAGE_MYSQL: "docker.io/mysql:8.1.0"
DOCKER_IMAGE_MYSQL: "docker.io/mysql:8.4.0"
DOCKER_IMAGE_PERMISSIONS: "{{ DOCKER_REGISTRY }}overhangio/openedx-permissions:{{ TUTOR_VERSION }}"
# https://hub.docker.com/_/redis/tags
DOCKER_IMAGE_REDIS: "docker.io/redis:7.2.4"
Expand Down

0 comments on commit 3d5e8fa

Please sign in to comment.