-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UTC datetimes everywhere #69
Open
rubik
wants to merge
3
commits into
owocki:master
Choose a base branch
from
rubik:all-utc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
# -*- coding: utf-8 -*- | ||
from __future__ import unicode_literals | ||
|
||
from django.db import models, migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('history', '0003_auto_20160330_1920'), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterField( | ||
model_name='balance', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True, db_index=True), | ||
), | ||
migrations.AlterField( | ||
model_name='balance', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='classifiertest', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True), | ||
), | ||
migrations.AlterField( | ||
model_name='classifiertest', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='deposit', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True, db_index=True), | ||
), | ||
migrations.AlterField( | ||
model_name='deposit', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='performancecomp', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True, db_index=True), | ||
), | ||
migrations.AlterField( | ||
model_name='performancecomp', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='predictiontest', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True), | ||
), | ||
migrations.AlterField( | ||
model_name='predictiontest', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='price', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True, db_index=True), | ||
), | ||
migrations.AlterField( | ||
model_name='price', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='trade', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True, db_index=True), | ||
), | ||
migrations.AlterField( | ||
model_name='trade', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
migrations.AlterField( | ||
model_name='traderecommendation', | ||
name='created_on', | ||
field=models.DateTimeField(auto_now_add=True, db_index=True), | ||
), | ||
migrations.AlterField( | ||
model_name='traderecommendation', | ||
name='modified_on', | ||
field=models.DateTimeField(auto_now=True), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# -*- coding: utf-8 -*- | ||
from __future__ import unicode_literals | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('history', '0004_auto_20160409_1213'), | ||
] | ||
|
||
operations = [ | ||
migrations.RemoveField( | ||
model_name='balance', | ||
name='date_str', | ||
), | ||
migrations.RemoveField( | ||
model_name='deposit', | ||
name='created_on_str', | ||
), | ||
migrations.RemoveField( | ||
model_name='performancecomp', | ||
name='created_on_str', | ||
), | ||
migrations.RemoveField( | ||
model_name='price', | ||
name='created_on_str', | ||
), | ||
migrations.RemoveField( | ||
model_name='trade', | ||
name='created_on_str', | ||
), | ||
migrations.RemoveField( | ||
model_name='traderecommendation', | ||
name='created_on_str', | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has no effect since,
auto_now_add
is used for modified_on?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We are in the situation described here:
#75 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @owocki intention was to capture the time of creation on the poloniex server with this.
A proposal could be we add
deposit_created_on
toDeposit
model and usecreated_on
for the creation of the model in our database.In short:
deposit_created_on
- time of creation at poloniex servercreated_on
- time of saving in our databaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. The only downside of this approach is that we will have to remember to use
deposit_created_on
instead ofcreated_on
.