Skip to content

Commit

Permalink
Network argument is broken so we're removing it (#549)
Browse files Browse the repository at this point in the history
* Network argument is broken so we're removing it

`--network` has been retired as of v16 and it is redundant to `--data-dir`. We've tested it on both v15 and v16 and the omission of this does not break backwards compatability.

* regen tests
  • Loading branch information
orcutt989 authored Feb 17, 2023
1 parent c5e8e7b commit 8e8258a
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
3 changes: 1 addition & 2 deletions charts/tezos/scripts/snapshot-importer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ if [ -f ${node_dir}/chain.snapshot.block_hash ]; then
block_hash_arg="--block $(cat ${node_dir}/chain.snapshot.block_hash)"
fi

${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir} \
--network $CHAIN_NAME ${block_hash_arg}
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir}
find ${node_dir}

rm -rvf ${snapshot_file}
3 changes: 1 addition & 2 deletions test/charts/mainnet.expect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,7 @@ spec:
block_hash_arg="--block $(cat ${node_dir}/chain.snapshot.block_hash)"
fi
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir} \
--network $CHAIN_NAME ${block_hash_arg}
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir}
find ${node_dir}
rm -rvf ${snapshot_file}
Expand Down
6 changes: 2 additions & 4 deletions test/charts/mainnet2.expect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,7 @@ spec:
block_hash_arg="--block $(cat ${node_dir}/chain.snapshot.block_hash)"
fi
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir} \
--network $CHAIN_NAME ${block_hash_arg}
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir}
find ${node_dir}
rm -rvf ${snapshot_file}
Expand Down Expand Up @@ -826,8 +825,7 @@ spec:
block_hash_arg="--block $(cat ${node_dir}/chain.snapshot.block_hash)"
fi
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir} \
--network $CHAIN_NAME ${block_hash_arg}
${node} snapshot import ${snapshot_file} --data-dir ${node_data_dir}
find ${node_dir}
rm -rvf ${snapshot_file}
Expand Down

0 comments on commit 8e8258a

Please sign in to comment.