Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tezos signer forwarder #498
Tezos signer forwarder #498
Changes from 17 commits
2bbf0a3
035ee60
5f9918b
51fff35
55c4697
50944be
44681f0
e118947
c41de6c
4a43c1c
ce93950
6c42078
abe7a74
4edfd74
82906a6
c73fb8c
7cf5efe
1365856
642f81b
f8a670b
5eae094
104a3ea
3b978d0
bd66fd1
6817c1a
8835dba
ec63d9c
0ef9f7d
0aeda6a
826cef4
ca0376d
a915821
49cf3a9
e28f727
92accfe
db80342
b9a58c9
75d0549
133cff2
00d66e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe namespace should be used, otherwise resources will not be deployed in the correct ns. There are other resources as well missing the namespace field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I think helm always installs stuff in a specific namespace, and so does pulumi.
https://www.reddit.com/r/kubernetes/comments/uglbn3/should_i_define_the_namespace_metadata_info_on_my/
I've actually removed it wherever it was still set on this chart. I know it's different from all our other charts in this repo, so I'm ok to re-add them because of consistency, but by default I wouldn't because these lines don't do anything.