-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pyyaml to 6.0.1 #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure this should be merged yet. It is a major version update of a package which seems to be a dep of another. If the code hasn't been tested we don't know what will happen.
Please see my comment here: #595 (comment) |
Thanks @harryttd. Yes I looked at the PR and I wasn't able to understand the issue. It seems as if the arm64 build randomly stopped working for PyYAML 5.4. Could you elaborate on how the PR could be related? This seems more relevant possibly yaml/pyyaml#724 I did some research and along with the above- the consensus seems to be to upgrade to 6.0.1. Happy to wait, but we have a broken pipeline at the moment. |
I see now how the Cython PR is relevant. However I dont think its going to be fixed. |
Yeah.. as the days go on they don't seem to want to fix this for older versions yaml/pyyaml#731 Did you test the code to make sure it still works with the major release version? |
We are not doing anything fancy with pyyaml so I'll assume it can still parse our yaml fine. |
Fixes broken pyyaml arm64 build in our CI.