New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git remove unused features unsafe_deterministic_data and bake_using_account #617

Merged

nicolasochem merged 2 commits into master from remove_unsafe_deterministic

Jan 15, 2024

Collaborator

nicolasochem commented Dec 16, 2023 •

edited

Loading

unsafe_data was a method to deterministically generate accounts when none is passed in values.yaml. It was used long time ago for some scaling tests, but not since. It's better to require to pass account keys in the values file, so we are making it mandatory
bake_using_account is a remnant of when you could only bake for one account per baker. Now, we use bake_using_accounts: []. Removing this old format allows to remove some lines of code.

Also remove devspace files - devspace is a tool to work on k8s containers remotely, but we haven't been using it.

nicolasochem added 2 commits

December 15, 2023 21:35


          remove unused features unsafe_deterministic_data and bake_using_account

dbb58de


          remove devspace and rpc-auth

a91ba32

nicolasochem marked this pull request as ready for review

January 15, 2024 18:21

nicolasochem merged commit 1d709f6 into master

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet