Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: add propsToParse to common logger #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vlopes
Copy link

@vlopes vlopes commented Dec 3, 2020

Descricao

Esse PR tem como objetivo adicionar uma camada de parse para o objeto logger (seguindo o exemplo do httpConf).

Para isso passamos a aceitar mais um atributo no parametro de instanciacao chamado loggerConf com o intuito de receber configuracoes especificas pro logger. Esse novo parametro e um objeto e nesse primeiro momento aceitaremos apenas uma configuracao chamada propsToParse (seguindo a nomeclatura do httpConf), que tem como objetivo fazer o casting de valores.

@claytonsilva
Copy link

@vlopes consegue trazer junto teste evidenciando que chamando da forma antiga e nova tem o impacto desejado?
senti falta de teste evidenciando a entrega.

@coveralls
Copy link

coveralls commented Dec 3, 2020

Coverage Status

Coverage remained the same at 75.0% when pulling b8ab702 on add-parse-to-log into c777738 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants