Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pull requests which makes minor performance improvements to the libraries
filter
instead of spliceRemoving the use of splice and for loop in
destroy
method with filter since it's more efficient and IMO more clearer though.Additional discussions:
I did not make a PR with that, since that's a big function and there's only one scenario (when animation ends) we need to make any mutations to the array, so doing a filter will make the code clunky, but this is something I would like to discuss further.
have a nice day. thanks for this library