Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store lightnode activations #1309

Merged

Conversation

maharifu
Copy link
Contributor

@maharifu maharifu commented Oct 8, 2024

Related Github tickets

Background

Keep an on-chain list of activated lightnodes. When a new node is activated, we add it to the list. To bootstrap the list with the existing lightnodes, we add a new transaction. This is instead of a governance vote, so we don't waste more time. The transaction can be executed at any time after the upgrade.
For each lightnode we keep track of: address, activated timestamp, last authentication timestamp. This way we can also know which nodes are active and performing authentications.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@maharifu maharifu requested a review from taariq October 8, 2024 15:43
@maharifu maharifu changed the title Feat/store lightnode activations feat: store lightnode activations Oct 8, 2024
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and what we need! LFG!

@taariq taariq merged commit 49c31df into palomachain:master Oct 8, 2024
4 checks passed
@taariq taariq deleted the feat/store_lightnode_activations branch October 8, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment