Switch Inotify to irmin-watcher #65
Conversation
|
Thanks a lot, this is great! I had the plan to create a multiplatform filesystem watcher but independent of irmin ( Having your PR ready now is really nice for all Mac users! Thanks! |
panglesd
force-pushed
the
irmin-watcher
branch
from
f785399
to
eb71eff
Compare
| [%blob "compiler/src/bin/native/client/client.bc.js"] | ||
| [%blob "client/client.bc.js"] |
There was a problem hiding this comment.
Hmm it seems to work in both situation, is it some blob ppx magic? Anyway, the short form is better.
There was a problem hiding this comment.
The long form doesn't work when you vendor (in the dune sense) slipshow ^^"
There was a problem hiding this comment.
Ah yes! I understand. Thanks for the explanation :)
compiler/data/data_contents.ml
Outdated
There was a problem hiding this comment.
I think you have ocamlformatted this file, but there is a .ocamlformat in the directory which should have disabled that...
Can you revert the change?
| ; bos | ||
| )) | ||
| (preprocessor_deps | ||
| (file client/client.bc.js)) |
There was a problem hiding this comment.
From the dune manual, (file <filename>) and <filename> is the same. What is the reason to prefer on to the other?
There was a problem hiding this comment.
Oh that was from testing the ppx_blob issue I mentioned above
|
(The CI issue seems unrelated to this. I'll need to fix to do a release...) |
panglesd
force-pushed
the
irmin-watcher
branch
from
eb71eff
to
1d2f1a7
Compare
Irmin-watcher is a portable, filesystem notification library. On linux it uses inotify and on macOS it uses fsevents. It has a portable, if slow, polling mode too. This makes slipshow installable on macOS.
panglesd
force-pushed
the
irmin-watcher
branch
from
1d2f1a7
to
5edcb5c
Compare
Thanks for slips @panglesd !
Irmin-watcher is a portable, filesystem notification library. On linux it uses inotify and on macOS it uses fsevents. It has a portable, if slow, polling mode too.
This makes slipshow installable on macOS \o/
(( Sorry about all of the formatting that's been sucked into this PR :S -- feel free to cherry pick just the meaninful changes ))