341609 Add delivery block to Site #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-brousse
requested changes
Oct 17, 2024
db/schema.rb
Outdated
| @@ -485,6 +485,9 @@ | |||
| t.decimal "latitude" | |||
| t.decimal "longitude" | |||
| t.integer "rooms_count", default: 0, null: false | |||
| t.text "description" | |||
There was a problem hiding this comment.
Doesn't match with migration
app/views/sites/show.html.erb
Outdated
| <dd class="mb-0 pb-2 ps-3"> | ||
| <% if @site.delivery_map.attached? %> | ||
| <%= link_to @site.delivery_map, rel: :noopener, target: :_blank do %> | ||
| <%= image_tag @site.delivery_map, class: "w-100" %> |
There was a problem hiding this comment.
Use a representation with resize. Here if use upload a pdf, it will do an image of first page at least.
| @@ -7,6 +7,8 @@ class Site < ApplicationRecord | |||
| has_many :rooms, dependent: :restrict_with_error | |||
| has_many :frames, through: :rooms, dependent: :restrict_with_error | |||
|
|
|||
| has_one_attached :delivery_map | |||
There was a problem hiding this comment.
Maybe we could add some format and size validation?
app/views/sites/_form.html.erb
Outdated
| <%= f.label :delivery_map, class: "form-label" %> | ||
| <%= f.file_field :delivery_map, class: "form-control" %> | ||
| <% if @site.delivery_map.attached? %> | ||
| <%= image_tag @site.delivery_map.variant(resize_to_limit: [200, 200]), class: "ms-0 mt-2" %> |
There was a problem hiding this comment.
Suggested change
| <%= image_tag @site.delivery_map.variant(resize_to_limit: [200, 200]), class: "ms-0 mt-2" %> | |
| <%= image_tag @site.delivery_map.representation(resize_to_limit: [200, 200]), class: "ms-0 mt-2" %> |
Prefer representation to manage other files than images (ex: pdf)
B-Rass
force-pushed
the
341609-add-delivery-block-to-site
branch
from
388a822
to
2fe812d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.