Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clip pixel buffer when larger than surface texture #190

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

parasyte
Copy link
Owner

@parasyte parasyte commented Sep 2, 2021

@parasyte
Copy link
Owner Author

parasyte commented Sep 2, 2021

@BlackHoleFox, please try this branch. If it works for you, I'll consider that a positive review of the PR. 😜

Also note that this branch is based on wgpu 0.10 ... There aren't many public API changes except for reexports and one of the error variants had a name change. It should be a very easy upgrade.

@BlackHoleFox
Copy link

@parasyte I swapped in this branch and it was pretty much a drop-in replacement. The results are great too :) No wgpu errors occur and the top bit of the image is no longer missing either, which makes a large improvement over the previous branch I was trying out.

@parasyte
Copy link
Owner Author

parasyte commented Sep 2, 2021

Thanks for confirmation! I'll go with this PR as-is and create a new release soon.

@parasyte parasyte merged commit b00c65f into master Sep 2, 2021
@parasyte parasyte deleted the fix/186 branch September 2, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Larger resolutions fail to render
2 participants