split event handlers #227
Merged
split event handlers #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| constructor(message: string = "Something went wrong with event handler data") { | ||
| super(message); | ||
| } | ||
| } |
There was a problem hiding this comment.
It feels like it would be considerably simpler, if the handlers were context-free, and the ctx, payload, octokit, parsedCommand would be normal arguments.
There was a problem hiding this comment.
i started making it like this, but then too many things could be re-used, so I made it like this. Ultimately there are downsides and things that could look better in both approaches imo
mutantcornholio
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify the onIssueCommentCreated.ts handler I have split it into more granular parts
I wanted to store handlers in different files so it's easier to navigate