Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of fix Pools 6->7 migration (#2942) (#3094) #3220

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Backport of fix Pools 6->7 migration (#2942) (#3094) #3220

merged 4 commits into from
Feb 12, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Feb 6, 2024 •
edited
Loading

This is a cherry-pick of #3094 (patch to release-polkadot-v1.5.0).

This should result as a patched 24.0.1 version for https://crates.io/crates/pallet-nomination-pools/24.0.0.

Relates to: polkadot-fellows/runtimes#137

@bkontur @ggwpez
@alvicsam @seadanda @bkchr @acatangiu @pgherveou
Backport of fix Pools 6->7 migration (#2942) (#3094)
6d7516f 
This should result as a patched `24.0.1` version for
https://crates.io/crates/pallet-nomination-pools/24.0.0.

Relates to: polkadot-fellows/runtimes#137

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: PG Herveou <pgherveou@gmail.com>
@bkontur bkontur requested review from andresilva and a team as code owners February 6, 2024 09:22
@bkontur bkontur added the R0-silent Changes should not be mentioned in any release notes label Feb 6, 2024
@liamaharon
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 12, 2024 •
edited
Loading

@liamaharon https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5178447 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-50e7eef8-c6b7-4ddc-bca3-26cd532c11ce to cancel this command or bot cancel to cancel all commands in this pull request.

@bkontur bkontur requested a review from athei as a code owner February 12, 2024 08:46
@command-bot
Copy link

command-bot bot commented Feb 12, 2024

@liamaharon Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5178447 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5178447/artifacts/download.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5178467

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5178466

liamaharon
liamaharon approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming checks have been done manually since ci doesn't work on this branch

@bkontur
Copy link
Contributor Author

bkontur commented Feb 12, 2024

Assuming checks have been done manually since ci doesn't work on this branch

yes, local cargo test and this patched migration is tested in fellows repo directly with check-migrations jobs: https://github.com/polkadot-fellows/runtimes/pull/137/files#diff-efa4caeb17487ecb13d8f5eb7863c3241d84afa2e73fbf25909a2ca89df0f362R2783-R3082

@acatangiu acatangiu merged commit 47c253c into release-crates-io-v1.5.0 Feb 12, 2024
20 of 84 checks passed
@acatangiu acatangiu deleted the bko-pools-migration-fix-to-1.5 branch February 12, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamaharon liamaharon liamaharon approved these changes

@acatangiu acatangiu acatangiu approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@athei athei Awaiting requested review from athei athei is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkontur @liamaharon @paritytech-cicd-pr @acatangiu