Small: Add option for making residual tolerance relative to rhs in BiCGSTAB #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrete
approved these changes
Jul 24, 2024
| @@ -34,18 +34,20 @@ namespace solvers { | |||
| struct BiCGSTABParams { | |||
| MGParams mg_params; | |||
| int max_iters = 1000; | |||
| Real residual_tolerance = 1.e-12; | |||
| std::shared_ptr<Real> residual_tolerance = std::make_shared<Real>(1.e-12); | |||
There was a problem hiding this comment.
Out of curiosity: Why is this shared pointer?
There was a problem hiding this comment.
So that it can be pulled out by a downstream code and updated within a task in a task list. Obviously this isn't completely necessary, but I think it makes it clearer that this can be updated elsewhere.
lroberts36
changed the base branch from
lroberts36/fix-iterative-task-qualifiers
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Allow for specifying the convergence tolerance in BiCGSTAB to be relative to the RMS of the input right hand side. Additionally, make the tolerance a shared pointer so that it can be more cleanly updated within a downstream task list.
PR Checklist