Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address CUDA MPI/IPC issue with Kokkos <=4.4.1 #1189

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Address CUDA MPI/IPC issue with Kokkos <=4.4.1 #1189

merged 1 commit into from
Oct 15, 2024

Conversation

pgrete
Copy link
Collaborator

@pgrete pgrete commented Oct 15, 2024

PR Summary

PR Checklist

  • Code passes cpplint
  • New features are documented.
  • Adds a test for any bugs fixed. Adds tests for new features.
  • Code is formatted
  • Changes are summarized in CHANGELOG.md
  • Change is breaking (API, behavior, ...)
    • Change is additionally added to CHANGELOG.md in the breaking section
    • PR is marked as breaking
    • Short summary API changes at the top of the PR (plus optionally with an automated update/fix script)
  • CI has been triggered on Darwin for performance regression tests.
  • Docs build
  • (@lanl.gov employees) Update copyright on changed files

bprather
bprather approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@bprather bprather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm setting this exactly this way downstream after many user complaints

@brryan
Copy link
Collaborator

brryan commented Oct 15, 2024

Yep LGTM especially since we don't use streams. Thanks @pgrete!

lroberts36
lroberts36 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@lroberts36 lroberts36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brryan brryan enabled auto-merge (squash) October 15, 2024 21:45
@brryan brryan merged commit b10d7b1 into develop Oct 15, 2024
53 checks passed
@pgrete pgrete deleted the pgrete/disable-cuda-async branch October 16, 2024 07:33
@pgrete pgrete changed the title Address CUDA MPI/ICP issue with Kokkos <=4.4.1 Address CUDA MPI/IPC issue with Kokkos <=4.4.1 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brryan brryan brryan approved these changes

@bprather bprather bprather approved these changes

@lroberts36 lroberts36 lroberts36 approved these changes

@fglines-nv fglines-nv Awaiting requested review from fglines-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgrete @brryan @bprather @lroberts36