-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Switch to V2 endpoints for some endpoints (#1281) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mildophin
requested review from
nmenetrier,
MatthieuMoreau0,
MohamedAminMallek,
oliver-gordon and
Augustinio
September 4, 2024 09:20
Technically if we remove a key from the response, doesn't it constitute a breaking change? If so the minor should be bumped. |
Indeed it is, just realised it, I will bump it to 0.13.0 |
Augustinio
approved these changes
Sep 5, 2024
nmenetrier
approved these changes
Sep 6, 2024
MohamedAminMallek
approved these changes
Sep 10, 2024
Mildophin
requested review from
MohamedAminMallek,
Augustinio and
nmenetrier
September 10, 2024 11:45
oliver-gordon
approved these changes
Sep 11, 2024
Mildophin
force-pushed
the
mv/switch-to-V2-endpoints
branch
from
September 11, 2024 13:59
3fd1afa
to
203e18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to V2 endpoints for the following endpoints:
The V2 remove the 'results' field in the response, field present in the V1 of these endpoints.
Checklist
Versioning (PASQAL developers only)
_version.py
following the changes in your PR and by using semantic versioning.Documentation
Tests
Internal tests pipeline (PASQAL developers only)
If your PR hasn't changed any functionality, it still needs to be validated against internal tests.
After updating the version (PASQAL developers only)