Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Switch to V2 endpoints for some endpoints (#1281) #135

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

Mildophin
Copy link
Collaborator

@Mildophin Mildophin commented Sep 4, 2024

Description

Switch to V2 endpoints for the following endpoints:

  • PUT cancel jobs
  • POST add jobs
  • PUT cancel batch
  • PUT complete batch
  • PUT cancel job

The V2 remove the 'results' field in the response, field present in the V1 of these endpoints.

Checklist

  • The title of the PR follows the right format: [{Label}] {Short Message}. Label examples: IMPROVEMENT, FIX, REFACTORING... Short message is about what your PR changes.

Versioning (PASQAL developers only)

  • Update the version of pasqal-cloud in _version.py following the changes in your PR and by using semantic versioning.

Documentation

  • Update CHANGELOG.md with a description explaining briefly the changes to the users.

Tests

  • Unit tests have been added or adjusted.
  • Tests were run locally.

Internal tests pipeline (PASQAL developers only)

  • Update and run the internal tests while targeting the branch of this PR.
    If your PR hasn't changed any functionality, it still needs to be validated against internal tests.

After updating the version (PASQAL developers only)

  • Open a PR on the internal tests that updates the version used for the pasqal-cloud backward compatibility tests.

@Augustinio
Copy link
Collaborator

Technically if we remove a key from the response, doesn't it constitute a breaking change? If so the minor should be bumped.

@Mildophin
Copy link
Collaborator Author

Technically if we remove a key from the response, doesn't it constitute a breaking change? If so the minor should be bumped.

Indeed it is, just realised it, I will bump it to 0.13.0

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Mildophin Mildophin merged commit 38f2a20 into dev Sep 11, 2024
5 checks passed
@Mildophin Mildophin deleted the mv/switch-to-V2-endpoints branch September 11, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants