Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Cancel batches #146

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

[FEAT] Cancel batches #146

wants to merge 6 commits into from

Conversation

Mildophin
Copy link
Collaborator

Description

This PR adds the feature of cancelling a group of batches.

Filters were refactored as they are the same for getting and cancelling jobs and the same too for getting and cancelling batches. Rebatch filters stay different though.

Also it was the opportunity to spot a missing feature of cancelling jobs by job status on the cancel jobs method, it is now fixed.

Breaking changes

Now the CancelJobFilters does not exist anymore, use JobFilters instead.

Checklist

  • The title of the PR follows the right format: [{Label}] {Short Message}. Label examples: IMPROVEMENT, FIX, REFACTORING... Short message is about what your PR changes.

Versioning (PASQAL developers only)

  • Update the version of pasqal-cloud in _version.py following the changes in your PR and by using semantic versioning.

Documentation

  • Update CHANGELOG.md with a description explaining briefly the changes to the users.

Tests

  • Unit tests have been added or adjusted.
  • Tests were run locally.

Internal tests pipeline (PASQAL developers only)

  • Update and run the internal tests while targeting the branch of this PR.
    If your PR hasn't changed any functionality, it still needs to be validated against internal tests.

After updating the version (PASQAL developers only)

  • Open a PR on the internal tests that updates the version used for the pasqal-cloud backward compatibility tests.

@Mildophin Mildophin self-assigned this Oct 14, 2024
@Mildophin Mildophin marked this pull request as ready for review October 14, 2024 16:44
Copy link
Collaborator

@Augustinio Augustinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something to the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants