Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove binary serialization #465

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Remove binary serialization #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions Src/Fido2.Models/Exceptions/Fido2MetadataException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
using System;
using System.Runtime.Serialization;
namespace Fido2NetLib;

namespace Fido2NetLib;

[Serializable]
public class Fido2MetadataException : Exception
{
public Fido2MetadataException()
Expand All @@ -17,8 +13,4 @@ public Fido2MetadataException(string message) : base(message)
public Fido2MetadataException(string message, Exception innerException) : base(message, innerException)
{
}

protected Fido2MetadataException(SerializationInfo info, StreamingContext context) : base(info, context)
{
}
}
5 changes: 0 additions & 5 deletions Src/Fido2.Models/Exceptions/Fido2VerificationException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

namespace Fido2NetLib;

[Serializable]
public class Fido2VerificationException : Exception
{
public Fido2VerificationException()
Expand All @@ -30,9 +29,5 @@ public Fido2VerificationException(string message, Exception innerException) : ba
{
}

protected Fido2VerificationException(SerializationInfo info, StreamingContext context) : base(info, context)
{
}

public Fido2ErrorCode Code { get; }
}
8 changes: 1 addition & 7 deletions Src/Fido2.Models/UndesiredMetadataStatusFido2VerificationException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
using System;
using System.Runtime.Serialization;

namespace Fido2NetLib;
namespace Fido2NetLib;

/// <summary>
/// Exception thrown when a new attestation comes from an authenticator with a current reported security issue.
/// </summary>
[Serializable]
public class UndesiredMetadataStatusFido2VerificationException : Fido2VerificationException
{
public UndesiredMetadataStatusFido2VerificationException(StatusReport statusReport) : base($"Authenticator found with undesirable status. Was {statusReport.Status}")
{
StatusReport = statusReport;
}

protected UndesiredMetadataStatusFido2VerificationException(SerializationInfo info, StreamingContext context) : base(info, context) { }

/// <summary>
/// Status report from the authenticator that caused the attestation to be rejected.
/// </summary>
Expand Down
Loading