Saving PDF's #27
Closed
Saving PDF's #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been merged in? |
|
Unfortunately not. I don't quite understand the use case here, can someone who needs this functionality explain why they need it? Is there any reason why you can't batch process the pngs into a PDF later using something like imagemagick? |
|
Creating PDFs directly lets you have a vector-based "screenshot" that can be printed or enlarged, whereas converting a png to a pdf gives a lower-resolution final product. |
Open
|
This pull request is stale and can't be merged, but you've convinced me this is a good idea so I've opened a new issue (#49) to make sure it happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the ability to save PDF's of web pages.