Adding more detailed documentation of the API, build process, etc #23
Conversation
|
|
||
| `python expenditures/app.py` | ||
|
|
||
| Once running the app should auto-restart if you make any changes to the code base. The |
There was a problem hiding this comment.
Should probably either finish the sentence or drop the hanging The. 😝
| | ENV | The environment that you're working in which should be "dev" | | ||
| | cert | The firebase certificate used to connect to the firebase facts database (see below) | | ||
| | AWS_ACCESS_KEY_ID | AWS API Key | | ||
| | AWS_SECRET_ACCESS_KEY | AWS Secret Key | |
There was a problem hiding this comment.
Would be nice to provide an example of setting these env vars. Maybe even add a .env-sample file to the repo?
|
|
||
| Questions about how the deploy works? Talk to Steve (steve_stearns on the digital team Slack) | ||
| Be sure that when you set up your local environment that the JSON for the firebase | ||
| certificate is properly escaped. |
There was a problem hiding this comment.
Add a little bit of clarification here? Should it arrive properly escaped?
Also maybe add a "(see below)" after "firebase certificate".
| files. No muss. No fuss. | ||
| | Variable | Description | | ||
| |:----------------------|:------------------------------------------------------------------------------------| | ||
| | ENV | The environment that you're working in which should be "dev" | |
There was a problem hiding this comment.
For my own clarification, once we get a local option that doesn't use AWS, should this value still be dev locally? Should we specify a value of local when I've got Redis running for local dev in place of AWS?
There was a problem hiding this comment.
I'm not sure that makes sense to have redis in place of dynamo locally as it uses two different technologies. That said I think it'd make sense to just keep it as dev, whichever way we go with the local environment.
No description provided.