This repository has been archived by the owner on May 23, 2023. It is now read-only.
permissions for android 10+, default subscription id, refactor #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default subscription id additional permissions slight refactor: - reduced nesting - slightly more descriptive methods - grouped by permission and data level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on kitrio branch, fix for permission issues on android 10+.
READ_PHONE_STATE is not enough to access full data, additional READ_PHONE_NUMBERS is required. Permissions got refactored into array, which should allow for easier modifications.
I've refactored code a bit - created grouping methods that may slightly better describe what is where accessed, and reduced nesting here and there.
alborrajo's default subscription id is included, but on condition getActiveSubscriptionInfoList returns non-empy list. I've included this change here, because my PR changes code a bit and merging would be tricky