Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV support #16

Closed
wants to merge 1 commit into from
Closed

Conversation

ppai-plivo
Copy link

@ppai-plivo ppai-plivo commented Apr 8, 2020

Running fetch.js now also generates mcc-mnc-list.csv file.

$ ls -lh mcc-mnc-list.*
-rw-r--r--  1 user  staff   283K Apr  8 13:36 mcc-mnc-list.csv
-rw-r--r--  1 user  staff   763K Apr  8 13:23 mcc-mnc-list.json

Closes: #15

@@ -4,6 +4,7 @@ const fs = require('fs');
const path = require('path');
const jsdom = require('jsdom');
const { JSDOM } = jsdom;
const csvstringify = require('csv-stringify/lib/sync')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppai-plivo
Copy link
Author

@pbakondy please let me know if this is ok.

@pbakondy
Copy link
Owner

pbakondy commented Apr 9, 2020

@ppai-plivo please include only the code changes without the generated files in your patch

@ppai-plivo
Copy link
Author

@ppai-plivo please include only the code changes without the generated files in your patch

Done 👍

I hope that next time you run fetch.js and update the list, mcc-mnc-list.csv is checked in and makes it to the repo. I need it to be downloadable from github, similar to mcc-mnc-list.json file.

@ppai-plivo
Copy link
Author

@pbakondy Can you please take a look again ? Thanks.

Running `fetch.js` now also generates `mcc-mnc-list.csv` file.

Signed-off-by: Prashanth Pai <prashanth.pai@plivo.com>
@ppai-plivo
Copy link
Author

Bump!

@ppai-plivo ppai-plivo closed this Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV format support ?
2 participants