-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace peercoin lib with bitcore-lib #14
base: master
Are you sure you want to change the base?
Conversation
usage of bitcore-lib as seen in peerscript-labs
This is much better solution, much more maintainable. Not sure why it was not done like this from day one. |
I'm getting this error when running locally:
Also, the reason why I manually added peercoin lib instead of using other solutions is to make sure the project would stay small. Most libs are made with back-end as target, which means there is no effort to make them light. Most have way too much "bloatware" and helper functions we wouldn't need in order to generate a wallet. But I'm open to testing the size difference from your implementation, if it's not too much, we can adopt it. |
your node version is ancient: |
also cherrypicked what is needed from library. Not sure is treeshaking works with this (if supported at all)
thx I can see it now in chrome browser. I was using Brave... |
I ll rewrite this with http://cryptocoinjs.com/modules/currency/coininfo/ then this weekend as it supports ppc I see... |
You know what: this project needs webpack. Without it, options are very limited as the usage of Buffer is everywhere. I can try to reduce the code in Peercoin lib as much as possible. |
Updating the bundler is a must, indeed. You should give your 2 cents on #15 later. |
usage of bitcore-lib as seen in peerscript-labs.
I think it is better to use bitcore-lib as is seen in peerscript-labs project, so I replaced it.
please review and merge